res_pjsip_rfc7329: add tests for new module res_pjsip_rfc7329#127
Open
mr-gmr wants to merge 1 commit intoasterisk:masterfrom
Open
res_pjsip_rfc7329: add tests for new module res_pjsip_rfc7329#127mr-gmr wants to merge 1 commit intoasterisk:masterfrom
mr-gmr wants to merge 1 commit intoasterisk:masterfrom
Conversation
Author
|
cherry-pick-to: 20 |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck failed |
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
c03eefc to
7dcdde7
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck failed |
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
7dcdde7 to
49abdef
Compare
github-actions
bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
49abdef to
1cc1aea
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck failed |
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
1cc1aea to
740eda5
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
|
Workflow PRCheck failed |
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
740eda5 to
2c1ca27
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-failed
labels
|
Workflow PRCheck failed |
Author
|
I don't even understand what's wrong with the tests here. Locally, everything passes... |
gtjoseph
previously requested changes
Mar 2, 2026
Member
gtjoseph
left a comment
gtjoseph
left a comment
There was a problem hiding this comment.
- Remove modules.conf from the tests that don't need to explicitly prevent it from loading.
- Remove extensions.conf from registration tests.
- Remove bob's scenario unless it's different from alice's
- Add checks to the tests that don't have them or remove the tests since they don't actually test anything.
tests/channels/pjsip/rfc7329/disabled_no_session_id_registration/test-config.yaml
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/disabled_no_session_id_registration/test-config.yaml
Outdated
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/disabled_no_session_id_registration/configs/ast1/extensions.conf
Outdated
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/disabled_no_session_id_registration/configs/ast1/modules.conf
Outdated
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/disabled_no_session_id_registration_unloaded/test-config.yaml
Show resolved
Hide resolved
...s/channels/pjsip/rfc7329/enabled_dialog_generation_registration/configs/ast1/extensions.conf
Outdated
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/enabled_dialog_generation_registration/test-config.yaml
Show resolved
Hide resolved
tests/channels/pjsip/rfc7329/enabled_dialog_generation_registration_unloaded/test-config.yaml
Show resolved
Hide resolved
Add a dedicated rfc7329 test suite under tests/channels/pjsip for asterisk/asterisk#1713 UserNote: The suite covers options , registration, invite/refer scenarios. rfc7329 enabled and disabled behavior. Module loaded and unloaded variants. Caller/callee dialogs across active scenarios . REFER flows including Refer-To Session-ID storage (alice/bob/charlie)
mr-gmr
force-pushed
the
master-added-res_pjsip_rfc7329
branch
from
2c1ca27 to
e0a9b2e
Compare
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
|
Workflow Check completed successfully |
gtjoseph
approved these changes
Mar 5, 2026
Member
|
Just for future reference... Users don't see testsuite commits so no need for UserNote, UpgradeNote, etc. The PR is good as it is though so no need to change anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a dedicated rfc7329 test suite under tests/channels/pjsip for asterisk/asterisk#1713
UserNote: The suite covers options , registration, invite/refer scenarios. rfc7329 enabled and disabled behavior. Module loaded and unloaded variants. Caller/callee dialogs across active scenarios . REFER flows including Refer-To Session-ID storage (alice/bob/charlie)